Unused arguments in CMSIS-NN wrapper functions

microTVM
#1

Hi, we experimented with the CMSIS-NN demo introduced here: https://github.com/apache/tvm/pull/11013 Thanks a lot for enabling this!

It seems that parameters of your functions are unused in the case of the wrapped call to arm_convolve_wrapper_s8, namely filter_scale_ and input_scale.

Plus, according to the function signature they are int32 but they get a float array in the main function. I added an image of the main_0 function.

Could you explain the reason why these arguments exist? Thanks in advance!

@grant-arm @manupa-arm @ashutosh-arm @UlrikHjort @Khoi @MJKlaiberBosch @MJKlaiber

Screenshot from 2022-05-19 16-31-18
Screenshot from 2022-05-19 16-31-183308×734 158 KB

3 Likes
#2

@Mousius for visibility

#3

@grant-arm @Mousius Any updates on this? Sorry to bother you, but for us the CMSIS functionality is an awesome feature.

#4

Hi @SebastianBoblestETAS,

I believe this PR (https://github.com/apache/tvm/pull/11431) by @ashutosh-arm addresses the issue. It seems to be failing in CI at the moment. Today is a holiday in the UK, so it’s likely to be Monday before it gets looked at again.

#5

Hi @grant-arm, thanks a lot for the quick reply! Have a nice weekend!

1 Like
#6

This https://github.com/apache/tvm/pull/11431 has been merged today.

#7

Hi @SebastianBoblestETAS . this PR has been merged now.

2 Likes