It’s a bit saddening to have to post this reminder, can everyone ensure they’ve read the code review guidelines. One of the most important things to consider here is the following extract from the original post (Improve Code Review Guideline):
Looking at the list of merged PRs against main (ignoring unity
as that’s been clarified as intentionally disregarding the guidelines), it’s clear that this isn’t being respected as PRs are being merged without giving any visibility to the wider community:
- https://github.com/apache/tvm/pull/14056 - 5 hrs
- https://github.com/apache/tvm/pull/14051 - 7 hrs
- https://github.com/apache/tvm/pull/14048 - 5 hrs
- https://github.com/apache/tvm/pull/14046 - 6 hrs - weekend merge
- https://github.com/apache/tvm/pull/14036 - 12 hrs - weekend merge
- https://github.com/apache/tvm/pull/14030 - 10 hrs - weekend merge
- https://github.com/apache/tvm/pull/14027 - 7 hrs - weekend merge
- https://github.com/apache/tvm/pull/14024 - 5 hrs - weekend merge
- https://github.com/apache/tvm/pull/14023 - 16 hrs - weekend merge
- https://github.com/apache/tvm/pull/14022 - 26 hrs - weekend merge
- https://github.com/apache/tvm/pull/14020 - 25 hrs - weekend merge
- https://github.com/apache/tvm/pull/14017 - 12 hrs
- https://github.com/apache/tvm/pull/14011 - 5 hrs
- https://github.com/apache/tvm/pull/14007 - 5 hrs
- https://github.com/apache/tvm/pull/14005 - 8 hrs
Allow some breathing space when introducing changes, this is an open community and we should be inclusive - even if it means just holding a PR open for 24 hours so every time zone has seen it or waiting for the end of the next working day rather than merging when people aren’t available. Remember, we want diversity of thought, allowing the views of many to help influence the software we build rather than excluding those who may have great insights from ever noticing a change was made.