It’s a bit saddening to have to post this reminder, can everyone ensure they’ve read the code review guidelines. One of the most important things to consider here is the following extract from the original post (Improve Code Review Guideline):
Looking at the list of merged PRs against main (ignoring unity
as that’s been clarified as intentionally disregarding the guidelines), it’s clear that this isn’t being respected as PRs are being merged without giving any visibility to the wider community:
- [BYOC] Update CUTLASS backend (SIMT support and codegen clean up) by masahi · Pull Request #14056 · apache/tvm · GitHub - 5 hrs
- [Runtime] Add missing Type2Str for TVMByteArray by wrongtest-intellif · Pull Request #14051 · apache/tvm · GitHub - 7 hrs
- [WEB] WebGPU Codegen by tqchen · Pull Request #14048 · apache/tvm · GitHub - 5 hrs
- [WEB] Update web runtime to support latest emcc by tqchen · Pull Request #14046 · apache/tvm · GitHub - 6 hrs - weekend merge
- [AutoScheduler][AutoTVM] Enable xgboost >= 1.7.x new changes by cbalint13 · Pull Request #14036 · apache/tvm · GitHub - 12 hrs - weekend merge
- [TIR] Update block flags and simplify predicate in Reverse-Compute-Inline by vinx13 · Pull Request #14030 · apache/tvm · GitHub - 10 hrs - weekend merge
- [FIX][TOPI] Clip with IntImm/FloatImm by MasterJH5574 · Pull Request #14027 · apache/tvm · GitHub - 7 hrs - weekend merge
- [FIX][RUNTIME] Convert container with function value type by MasterJH5574 · Pull Request #14024 · apache/tvm · GitHub - 5 hrs - weekend merge
- [TIR] [Bugfix] Pass the correct block_sref_reuse to Replace by quic-sanirudh · Pull Request #14023 · apache/tvm · GitHub - 16 hrs - weekend merge
- [TOPI] Fix index dtype in topi strided_slice by wrongtest-intellif · Pull Request #14022 · apache/tvm · GitHub - 26 hrs - weekend merge
- https://github.com/apache/tvm/pull/14020 - 25 hrs - weekend merge
- Refactor test to make it easier for user to understand how tensor_intrin works by new-TonyWang · Pull Request #14017 · apache/tvm · GitHub - 12 hrs
- [ACL][TESTING] Use pytest.mark.parametrize in ACL conv2d tests by ekalda · Pull Request #14011 · apache/tvm · GitHub - 5 hrs
- [Build] Fix find_include_path when using TVM python package by jinhongyii · Pull Request #14007 · apache/tvm · GitHub - 5 hrs
- [CI][Flaky] Skip zephyr_qemu-x86 tests that are part of task_python_microtvm by ashutosh-arm · Pull Request #14005 · apache/tvm · GitHub - 8 hrs
Allow some breathing space when introducing changes, this is an open community and we should be inclusive - even if it means just holding a PR open for 24 hours so every time zone has seen it or waiting for the end of the next working day rather than merging when people aren’t available. Remember, we want diversity of thought, allowing the views of many to help influence the software we build rather than excluding those who may have great insights from ever noticing a change was made.