I had some issues with “#define TVM_DLL __declspec(dllimport)” in https://github.com/apache/incubator-tvm/blob/1ae7162f5e11d8244188b88fd99b6b1b635cd629/include/tvm/runtime/c_runtime_api.h#L56 when I was working on a project that uses the tvm runtime library on Windows.
It does not make sense to mark classes/functions to be imported from other DLLs since they are already implemented in TVM. Should this line of code be simply “#define TVM_DLL”? @jmorrill @jonso