Conda url in docker installer is outdated

shibuiwilliam · October 26, 2020, 12:34am

The url in the current conda installer is outdated. https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh should be updated to https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh .

shibuiwilliam · October 26, 2020, 12:35am

right here.

github.com

apache/incubator-tvm/blob/main/docker/install/ubuntu_install_conda.sh#L23


# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied.  See the License for the
# specific language governing permissions and limitations
# under the License.

set -e
set -u
set -o pipefail

cd /tmp && wget -q https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh
chmod +x Miniconda3-latest-Linux-x86_64.sh
/tmp/Miniconda3-latest-Linux-x86_64.sh -b -p /opt/conda
rm /tmp/Miniconda3-latest-Linux-x86_64.sh
/opt/conda/bin/conda upgrade --all
/opt/conda/bin/conda clean -ya
/opt/conda/bin/conda install conda-build conda-verify
chmod -R a+w /opt/conda/

leandron · October 26, 2020, 10:58am

Hi @shibuiwilliam, I think you are correct. Would you mind sending a PR n GitHub to fix that?

edit: Yeah, I noticed, it is already there:

github.com/apache/tvm

[Fix,Conda] update conda download url

main ← tier4:conda

opened 01:17AM - 26 Oct 20 UTC

shibuiwilliam

+1 -1

What: a small change to update conda download url. Thanks for contributing to… TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.

shibuiwilliam · October 26, 2020, 10:41pm

Thanks @leandron Seems it’s merged.