Should we delete NNVM?

Development
#1

It’s been deprecated a long time ago. Is it still maintained? If not, I suggest that we delete it.

#2

I think mxnet still depends on it. @tqchen @junrushao

#3

I agree we should find plans to coordinate and deprecate NNVM. perhaps allowing mxnet to ref to the v0.8 version or obtain a local copy

#4

Does anyone else depend on NNVM? If not, we are happy to either receive the code donation from TVM, or fork a version and maintain it in MXNet. Otherwise, let us know who the other dependencies are and we can coordinate.

#5

I am not aware of other dependencies. I agree that fork and maintain in mxnet would be a good path forward.

1 Like
#6

Let us leave this thread open for another week. Then proceed with the removal if there are no more updates

1 Like
#7

Once concluded, would you like to proceed with code donation? Do we need to go through IP clearance?

#8

Personally I think PR with the code should be sufficient. Considering the code is already licensed to ASF. We also hold the original copyright so unlikely there will be an issue.

#9

I know this is a potentially controversial option, but MXNet has robust onnx export support and TVM’s onnx importer is quite good these days. We could deprecate both nnvm and the current MXNet importer and replace it from_mxnet with an internal conversion to onnx. Would that cause any major issues?

#10

I think this can be a followup separate convo. But the from_mxnet choice does not depend on nnvm’s availability in tvm codebase

#11