Hi All,
On executing Pylint on tvm (in incubator-mxnet) with the undefined-variable option, 47 errors show up. These errors could lead to Python NameError at runtime. Is there a plan to include these lint checks and fix them?
| Code/module affected | Undefined variable |
|---|---|
| ./tvm/dmlc-core/tracker/dmlc_tracker/mpi.py:20:13: | cmd |
| ./tvm/nnvm/python/nnvm/_base.py:151:44: | mx_float |
| ./tvm/nnvm/python/nnvm/_base.py:156:16: | mx_float |
| ./tvm/nnvm/python/nnvm/symbol.py:52:20: | add_symbol |
| ./tvm/nnvm/python/nnvm/symbol.py:54:20: | add_scalar |
| ./tvm/nnvm/python/nnvm/symbol.py:64:20: | sub_symbol |
| ./tvm/nnvm/python/nnvm/symbol.py:66:20: | sub_scalar |
| ./tvm/nnvm/python/nnvm/symbol.py:72:20: | rsub_scalar |
| ./tvm/nnvm/python/nnvm/symbol.py:79:20: | mul_symbol |
| ./tvm/nnvm/python/nnvm/symbol.py:81:20: | mul_scalar |
| ./tvm/nnvm/python/nnvm/symbol.py:91:20: | div_symbol |
| ./tvm/nnvm/python/nnvm/symbol.py:93:20: | div_scalar |
| ./tvm/nnvm/python/nnvm/symbol.py:99:20: | rdiv_scalar |
| ./tvm/nnvm/python/nnvm/symbol.py:112:20: | pow_symbol |
| ./tvm/nnvm/python/nnvm/symbol.py:114:20: | pow_scalar |
| ./tvm/nnvm/python/nnvm/symbol.py:120:20: | rpow_scalar |
| ./tvm/nnvm/python/nnvm/frontend/tensorflow.py:291:51: | axis |
| ./tvm/nnvm/python/nnvm/testing/tf.py:216:52: | image |
| ./tvm/nnvm/tests/python/frontend/tensorflow/test_forward.py:325:5: | test_concat_v2 |
| ./tvm/python/tvm/api.py:522:19: | Range |
| ./tvm/python/tvm/codegen.py:20:12: | _Build |
| ./tvm/python/tvm/make.py:31:12: | _range_by_min_extent |
| ./tvm/python/tvm/make.py:59:20: | Broadcast |
| ./tvm/python/tvm/make.py:60:12: | Cast |
| ./tvm/python/tvm/make.py:87:12: | _Node |
| ./tvm/python/tvm/make.py:106:21: | Evaluate |
| ./tvm/python/tvm/make.py:107:41: | Block |
| ./tvm/python/tvm/make.py:108:28: | Evaluate |
| ./tvm/python/tvm/module.py:23:16: | _GetTypeKey |
| ./tvm/python/tvm/module.py:38:16: | _GetSource |
| ./tvm/python/tvm/module.py:49:16: | _ImportsSize |
| ./tvm/python/tvm/module.py:50:17: | _GetImport |
| ./tvm/python/tvm/module.py:69:9: | _SaveToFile |
| ./tvm/python/tvm/module.py:111:25: | _PackImportsToC |
| ./tvm/python/tvm/module.py:185:12: | _GetSystemLib |
| ./tvm/python/tvm/module.py:222:12: | _LoadFromFile |
| ./tvm/python/tvm/module.py:244:12: | _Enabled |
| ./tvm/python/tvm/contrib/cc.py:87:12: | FileNotFoundError |
| ./tvm/python/tvm/contrib/cc.py:113:12: | FileNotFoundError |
| ./tvm/python/tvm/contrib/mps.py:32:13: | b |
| ./tvm/python/tvm/contrib/mps.py:34:13: | c |
| ./tvm/python/tvm/contrib/nnpack.py:17:5: | _Config |
| ./tvm/tests/python/unittest/test_pass_simplify.py:56:5: | test_modular |
| ./tvm/topi/python/topi/cpp.py:71:16: | ivec_get |
| ./tvm/topi/python/topi/cpp.py:90:16: | ivec_get |
| ./tvm/topi/python/topi/nn/batch_norm.py:54:25: | C |
| ./tvm/topi/python/topi/nn/batch_norm.py:55:24: | C |