BFloat enum value is conflict with kTVMNullptr enum value

Questions
#1

kDLBfloat enum value defined in dlpack.h is 4.
kTVMNullptr enum value defined in include/tvm/runtime/c_runtime_api.h is also 4.
So If we want to add kDLBfloat case in ArgTypeCode2Str, should we

  1. Change the enum value in one of them ?
  2. remove kTVMNullptr case ArgTypeCode2Str ? Which is prefer?

Thanks.

#2

ArgTypeCode2Str is intended for PackedFunc arguments so in this case we indeed do not support BFloat. We do need to find ways to change printings for normal DataType in this case.

#3

Thanks for replying.

So, according to this view, we should also remove kDLInt, kDLUInt, kDLFloat case in ArgTypeCode2Str after we finding new ways. Did I get that right ?

#4

We do need to keep int and float as they are part of the calling conv

#5

I see, int and float is defined in TVMValue union. Thanks a lot.